-
-
-
-
src/Lunr/Vortex/FCM/FCMPayload.php (Diff revision 1) Backticks? We don't use backticks as quotes anywhere else.
Also,
Data type
notData value
[Vortex] FCM: Throw exception if data value is not a string in the fcm payload
Review Request #1137 — Created April 19, 2024 and submitted
Information | |
---|---|
b.stoop | |
Lunr.Vortex | |
fcm/checkdatavalues | |
b965ede... | |
Reviewers | |
lunr | |
Based on master
FCM: Throw exception if data value is not a string in the fcm payload
Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8835759428
Summary: |
|
||||||
---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||
Commit: |
|
||||||
Diff: |
Revision 2 (+31 -2) |
-
-
src/Lunr/Vortex/FCM/FCMPayload.php (Diff revisions 1 - 2) array<string,mixed>
isn't correct though, because data values are only allowed to be strings.phpstan sees that the incoming value, according to phpdoc, is only allowed to be string, so
is_string()
will always returnTRUE
.I think the better fix here might be to ignore the specific phpstan error using
@phpstan-ignore
.
Testing Done: |
|
||||||
---|---|---|---|---|---|---|---|
Commit: |
|
||||||
Diff: |
Revision 3 (+31 -1) |