- Download Diff

Summary:

[Vortex] FCM: Throw exception if data value is not a string in the fcm payload

Review Request #1137 — Created April 19, 2024 and submitted April 25, 2024, 6:16 p.m.

Information
Owner:	b.stoop
Repository:	Lunr.Vortex
Branch:	fcm/checkdatavalues
Bugs:
Depends On:
Commit:	b965ede...
Reviewers
Groups:	lunr
People:

Description

Based on master

FCM: Throw exception if data value is not a string in the fcm payload

Testing Done

Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8835759428

Issues

0
0
4
0
All Issues: 4

Description	From	Last Updated
array<string,mixed> isn't correct though, because data values are only allowed to be strings. phpstan sees that the incoming value, according ...	pprkut	April 25, 2024, 6:02 p.m.
foreach ($data as &$value)	pprkut	April 23, 2024, 5:08 p.m.
=== FALSE	pprkut	April 23, 2024, 5:08 p.m.
Backticks? We don't use backticks as quotes anywhere else. Also, Data type not Data value	pprkut	April 23, 2024, 5:08 p.m.

src/Lunr/Vortex/FCM/FCMPayload.php (Diff revision 1)
Show all issues
```
foreach ($data as &$value)
```

src/Lunr/Vortex/FCM/FCMPayload.php (Diff revision 1)

Show all issues

=== FALSE

b.stoop April 23, 2024, 4:40 p.m.

phpstan is complaining about it: https://github.com/brianstoop/lunr.vortex/actions/runs/8801861811/job/24156247613

src/Lunr/Vortex/FCM/FCMPayload.php (Diff revision 1)

Show all issues

Backticks? We don't use backticks as quotes anywhere else.

Also, Data type not Data value

Summary:

-	[Lunr.Vortex] FCM: Throw exception if data value is not a string in the fcm payload
+	[Vortex] FCM: Throw exception if data value is not a string in the fcm payload

Testing Done:

~		Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8752067217
	~	Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8802778581

Commit:

-	60b73fd450ba8013009d1c7b3dc1c9da04840eea
+	fe73d60dc7edc78480e2f307c6dff587b049292b

Diff:

Revision 2 (+31 -2)

Show changes

	src/Lunr/Vortex/FCM/FCMPayload.php
	src/Lunr/Vortex/FCM/Tests/FCMPayloadSetTest.php

src/Lunr/Vortex/FCM/FCMPayload.php (Diff revisions 1 - 2)

Show all issues

array<string,mixed> isn't correct though, because data values are only allowed to be strings.
phpstan sees that the incoming value, according to phpdoc, is only allowed to be string, so is_string() will always return TRUE.
I think the better fix here might be to ignore the specific phpstan error using @phpstan-ignore.

Testing Done:

~		Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8802778581
	~	Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8835759428

Commit:

-	fe73d60dc7edc78480e2f307c6dff587b049292b
+	b965ede5371b8fd3ab92ab5d6ce939bc0511f9a6

Diff:

Revision 3 (+31 -1)

Show changes

	src/Lunr/Vortex/FCM/FCMPayload.php
	src/Lunr/Vortex/FCM/Tests/FCMPayloadSetTest.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (b965ede)

You have a pending review.

Review Board 3.0.24

[Vortex] FCM: Throw exception if data value is not a string in the fcm payload

Summary:

Testing Done:

Commit:

Diff:

Testing Done:

Commit:

Diff:

Status: Closed (submitted)

Change Summary: