-
-
-
src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1) file_get_contents
can returnFALSE
, even if the file exists.
[Vortex] FCM: Add method to set private key by file
Review Request #1133 — Created April 11, 2024 and updated
Information | |
---|---|
b.stoop | |
Lunr.Vortex | |
fcm/privatekeyfile | |
f308ffc... | |
Reviewers | |
lunr | |
Based on master
FCM: Add method to set private key by file
Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8704960012
Testing Done: |
|
||||||
---|---|---|---|---|---|---|---|
Commit: |
|
||||||
Diff: |
Revision 2 (+92) |
-
-
src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 2) "File does not exist is is not readable!"
Also, not really an
InvalidArgument
. Probably aRuntimeException
is best here, and below.
Testing Done: |
|
||||||
---|---|---|---|---|---|---|---|
Commit: |
|
||||||
Diff: |
Revision 3 (+93 -1) |