[Vortex] FCM: Add method to set private key by file

Review Request #1133 — Created April 11, 2024 and updated

b.stoop
Lunr.Vortex
fcm/privatekeyfile
f308ffc...
lunr

Based on master

FCM: Add method to set private key by file

Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8704960012

  • 1
  • 0
  • 3
  • 0
  • 4
Description From Last Updated
Isn't this duplicated by the check below? smillernl smillernl
pprkut
  1. 
      
  2. src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1)
     
     

    maybe is_readable() is better here

  3. src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1)
     
     

    file_get_contents can return FALSE, even if the file exists.

  4. 
      
b.stoop
pprkut
  1. 
      
  2. src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 2)
     
     

    "File does not exist is is not readable!"

    Also, not really an InvalidArgument. Probably a RuntimeException is best here, and below.

  3. 
      
b.stoop
Review request changed

Testing Done:

~  

Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8661774545

  ~

Github actions run: https://github.com/brianstoop/lunr.vortex/actions/runs/8704960012

Commit:

-7ff059b17b83c4f0d696229c115249b7a6445368
+f308ffcbccd2b3cfb5086109b5da0c4e05809aef

Diff:

Revision 3 (+93 -1)

Show changes

smillernl
  1. 
      
  2. src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 3)
     
     
     
     
     
     

    Isn't this duplicated by the check below?

  3. 
      
Loading...