This change has been marked as submitted.

Describe the submission (optional):

Merged into master

Reviews
Diff

- Download Diff

Summary:

[Gravity] remove escaping of wildcards in MySQLConnection::escape_string

Review Request #97 — Created May 31, 2013 and submitted 12 years ago — Latest diff uploaded 12 years ago

Information
Owner:	olivier*
Repository:	Lunr
Branch:	olivier:MySQL_escape
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

This review removes the escaping of "%" and "_" in MySQLConnection:escape_string method,
causing more issues than solving things and forcing to make use of workaround in client programs.

Testing Done

Unit tests

Diff Revision 1 (Latest)

	src/Lunr/Gravity/Database/MySQL/MySQLConnection.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLConnectionTest.php

Expand changes
Hide extra whitespace
Show extra whitespace
Hide whitespace changes
Show whitespace changes

src/Lunr/Gravity/Database/MySQL/MySQLConnection.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLConnectionTest.php

You have a pending review.

Review Board 3.0.24

This change has been marked as submitted.

[Gravity] remove escaping of wildcards in MySQLConnection::escape_string

Diff Revision 1 (Latest)