[Vortex] JPush: Change temporary error to deferred status in JpushReport

Review Request #969 — Created June 19, 2023 and discarded

Information
b.stoop
Lunr.Vortex
Jpush/temp
Reviewers
lunr 
Based on release/0.7.x


JPush: Change temporary error to deferred status in JpushReport
unit tests
  • 1
  • 0
  • 1
  • 0
  • 2
Description From Last Updated
I couldn't find that mentioned anywhere either. Can you link to the docs where you found this? :) pprkut pprkut
pprkut
pprkut 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Vortex/JPush/JPushReport.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    This does actually match with the message. Are you sure we don't need to resend the notification in this case?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I haven't really thought about this way, the jpush documentation isn't really clear about if the notification is sent out or not. Maybe it's best to stick with the initial implementation, worst case scenerio we would sent the notification twice.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




b.stoop




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Vortex/JPush/JPushReport.php
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    I couldn't find that mentioned anywhere either. Can you link to the docs where you found this? :)
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      There are not docs that mentions this. We initially implemented that this way, we also give the status temporary error status to the endpoints when the request for sending notifications returns a 50x status code. Because we don't have any docs on this I thought it would be best to stay with the initial implementation
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I'm confused :S
      
You're saying the initial implementation used temporary error, but the code changes it to deferred, and you're saying we should stay with the initial implementation. so... ? :)
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Yeah, its not really the initial implemention, I see. I meant with initial implementation that we retry the request. Do you think that when we get a 50x status code here, the notifications are not sent out?
      
 
      

      4. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




b.stoop




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...