[Lunr.Vortex] Remove fetching JPush report from JPush response

Review Request #951 — Created May 23, 2023 and submitted

b.stoop
Lunr.Vortex
jpush/removereport
953, 952
e1f6d95...
lunr

Based on release/0.7.x

Remove fetching JPush report from JPush response

unit tests

  • 0
  • 0
  • 4
  • 1
  • 5
Description From Last Updated
b.stoop
pprkut
  1. 
      
  2. src/Lunr/Vortex/JPush/JPushBatchResponse.php (Diff revision 1)
     
     
     
     
     
     
     
     

    we may need a way to get the message ID from the dispatcher

    1. I don't think that is necessary, the JPush dispatcher doesn't know about the message ID. We need a way to get the message ID from here to whatever calls the dispatcher

  3. src/Lunr/Vortex/JPush/JPushBatchResponse.php (Diff revision 1)
     
     
     
     
     
     
     

    This should return a special status that we can use to filter out endpoints that don't have a (final) status yet.

    UNKNOWN doesn't work, because that could be a final status.

  4. We don't need $this->statuses anymore I think

    1. We do, if the request to JPush fails and the notifications are not delivered we still need to show an error, hence the report_error method that checks for requests exceptions of the push call to JPush

  5. 
      
b.stoop
b.stoop
pprkut
pprkut
  1. 
      
  2. src/Lunr/Vortex/JPush/JPushBatchResponse.php (Diff revision 3)
     
     
     
     
     
     

    I'd like to keep this non-nullable

  3. The NULL handling can be here.

  4. 
      
b.stoop
pprkut
  1. Ship It!
  2. 
      
b.stoop
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release/0.7.x (2c78885)
Loading...