[Gravity] Add interface for database string escaping

Review Request #925 — Created March 6, 2023 and submitted

Information
pprkut
Lunr
926
e6a3aed...
Reviewers
lunr 
This provides a bit better separation of concerns and allows
more targeted mocking in the unit tests.
Unit tests
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
smillernl
smillernl 
  1. I think I'm just generally confused that the $db is an escaper instead of a database all of a sudden. Maybe change the variable naming if we don't need any of the database features anyway.
  2. Show all issues 
    The naming is confusing me here, maybe something like DatabaseEngineEscaperInterface is better?
  3. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




pprkut




   

   

  

 



 















 





 

  

   




smillernl




   

   







  

 



 

  


   

   

    
 
smillernl


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




pprkut




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release/0.7.x (2750860)





 


 










  

 









     

    

   

  

  

   
   Loading...