[Gravity] SQLiteDMLQueryBuilder

Review Request #92 — Created May 15, 2013 and discarded

Information
dinos
Lunr
dinostheo:SQLiteConnection
Reviewers
lunr 
This review contains the code for the sqlite query builder, as well as its unit tests.
https://github.com/dinostheo/lunr/tree/SQLiteDMLQueryBuilder

It depends on the http://reviews.lunr.nl/r/83/
https://github.com/dinostheo/lunr/tree/SQLiteConnection
which is necessary for the escaping methods only.

I also depends on http://reviews.lunr.nl/r/93/
for the delimiter.
unit tests
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
pprkut
pprkut 
  1. Location delimiter is still an unrelated change...
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




dinos




   

   

  

 



 















 



 

  

   




dinos




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Note that I do not mind the location delimiter as such. We will need something like that when implementing support for other databases (postgres, mssql, etc which do not support grave accents for identifiers). It's just an unrelated change and as such belongs in a separate review request.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    unnecessary with latest changes
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      It seems that I didn't understand the previous comment, but today I noticed the "unrelated" MySQLDMLQueryBuilder changes, which was coming from the SQLiteConnection changes.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




dinos




   

   

  

 



 















 



 

  

   




dinos




   

   

  

 



 















 





 

  

   




pprkut




   

   





  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This probably needs to be rebased against http://reviews.lunr.nl/r/94/
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




dinos




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 




 
Change Summary:

 
changes related to this review are posted in http://reviews.lunr.nl/r/86/





 


 










  

 









     

    

   

  

  

   
   Loading...