This change has been marked as submitted.

Describe the submission (optional):

Pushed to master (4ae5c38)

Summary:

[Gravity] Switch to procedural style to get affected/num rows

Review Request #918 — Created Feb. 15, 2023 and submitted 2 years, 3 months ago — Latest diff uploaded 2 years, 3 months ago

Description

This works around a type limitation in the unit tests that previously
broke tests on PHP 8.1+

The change is not necessary for MySQLQueryResult, but that's the more used version and it's probably good to keep both classes in sync.

Testing Done

Unit tests, functional tests in other projects

	src/Lunr/Gravity/Database/MySQL/MySQLAsyncQueryResult.php
	src/Lunr/Gravity/Database/MySQL/MySQLQueryResult.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLAsyncQueryResultBaseTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLAsyncQueryResultFetchTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLAsyncQueryResultTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLConnectionQueryTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultBaseTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultFailedTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultFreeTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultResultTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultSuccessTest.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultWarningTest.php

src/Lunr/Gravity/Database/MySQL/MySQLAsyncQueryResult.php

src/Lunr/Gravity/Database/MySQL/MySQLQueryResult.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLAsyncQueryResultBaseTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLAsyncQueryResultFetchTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLAsyncQueryResultTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLConnectionQueryTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultBaseTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultFailedTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultFreeTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultResultTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultSuccessTest.php

src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryResultWarningTest.php