[Vortex] Upgrade to Requests 2.x

Review Request #896 — Created Dec. 27, 2022 and submitted

pprkut
Lunr.Vortex
3432842...
lunr

Upgrade to Requests 2.x

Unit tests

  • 0
  • 0
  • 0
  • 2
  • 2
Description From Last Updated
There are no open issues
smillernl
  1. 
      
  2. The issue has been dropped. Show all issues

    I don't think the namespace is needed here

    1. Oh, no, it's not needed. I just left it for sake of clarity. We could write it out, like HTTP Response object or HTTP Request Session, but this was simpler and probably just as effective.

  3. src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1)
     
     
    The issue has been dropped. Show all issues

    Same here

  4. 
      
smillernl
  1. Ship It!
  2. 
      
pprkut
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (90b8188)
Loading...