pprkut
Description: |
|
|---|
[Core] add InterRequest class
Review Request #89 — Created April 26, 2013 and submitted
| Information | |
|---|---|
| olivier | |
| Lunr | |
| owizen:InterRequest | |
| 7315 | |
| Reviewers | |
| lunr | |
This class intends to wrap the Clirequest class to present it the same way as the core request class for consistency, the following should be reviewed first: http://reviews.lunr.nl/r/88/
Unit tests
-
-
src/Lunr/Core/InterRequest.php (Diff revision 1) restricting the inter request to only override on controller, method and parameters is just unnecessarily limiting future use cases. Let the user decide what to override.
-
src/Lunr/Core/InterRequest.php (Diff revision 1) If you let the user decide what to override this needs to get more flexible. Coincidentally it also gets much simpler in the process.
Change Summary:
Change made according to review possibility given to override all possible values
Summary: |
|
||||
|---|---|---|---|---|---|
Testing Done: |
|
||||
Diff: |
Revision 2 (+501 -123) |
Change Summary:
Uncomment tests cases in phpunit, properly rediffed and rebased
Diff: |
Revision 3 (+378) |
|---|
Change Summary:
Unit tests updated, fully mocks the parameters of constructor of the request class.
Diff: |
Revision 7 (+361) |
|---|
Change Summary:
corrects crash in phpunit: the test added to the Core Request class needed to be run in a separate process. Correct also doc mistake for this test and the argument passed to the tested function for both core and cli requests
Diff: |
Revision 10 (+347) |
|---|