[Lunr] Spark: Add types to FB API and SoapClient

Review Request #880 — Created Oct. 26, 2022 and submitted Dec. 23, 2022, 11:33 a.m.

Description

Spark: Add types to FB API and SoapClient

Testing Done

Issues

Description	From	Last Updated
It's not self though, it's static, but we have to wait for PHP 8.0 for that.	pprkut	Oct. 27, 2022, 2:48 p.m.
?	pprkut	Oct. 27, 2022, 2:47 p.m.
These type should be array\|null, right?	b.stoop	Nov. 9, 2022, 4:19 p.m.
I'm not sure if it's a requirement by the codestyle but shouldn't header be uppercased?	b.stoop	Dec. 12, 2022, 2:56 p.m.

src/Lunr/Spark/LunrSoapClient.php (Diff revision 1)

Show all issues

It's not self though, it's static, but we have to wait for PHP 8.0 for that.

	src/Lunr/Spark/LunrSoapClient.php
	src/Lunr/Spark/Facebook/Api.php

src/Lunr/Spark/LunrSoapClient.php (Diff revision 2)
Show all issues
```
These type should be array|null, right?
```

	src/Lunr/Spark/LunrSoapClient.php
	src/Lunr/Spark/Facebook/Api.php

Ship it!

src/Lunr/Spark/LunrSoapClient.php (Diff revision 3)

Show all issues

I'm not sure if it's a requirement by the codestyle but shouldn't header be uppercased?

I fixed it, but that didn't change in this review so it's unrelated.

Pushed to master (0f74370)

You have a pending review.