[Gravity] Fix NULL in strtoupper and exceptions

Review Request #879 — Created Oct. 26, 2022 and submitted

smillernl
Lunr
fix/gravity/81_fix_types
878
886
lunr

Accompanies https://github.com/M2mobi/lunr/pull/8

Exception constructors and strtoupper no longer accept NULL so this review makes sure that no longer happens.



  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
There are no open issues
pprkut
  1. 
      
  2. The issue has been resolved. Show all issues

    This should really not be needed

  3. 
      
smillernl
b.stoop
  1. 
      
  2. The issue has been resolved. Show all issues

    No longer needed

  3. src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    Needs a change too

  4. 
      
smillernl
b.stoop
  1. Ship It!
  2. 
      
smillernl
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (6af1dd9)
Loading...