Change Summary:
Make use of array_key_exists instead of isset to return the arguments associated to options.
Diff: |
Revision 2 (+112) |
---|
Review Request #87 — Created April 23, 2013 and discarded
Information | |
---|---|
olivier | |
Lunr | |
https://github.com/owizen/lunr/tree/CliRequest | |
7315 | |
Reviewers | |
lunr | |
Add the CliRequest class which makes use of the GetoptCliParser This review depends on http://reviews.lunr.nl/r/76/ from Heinz
Description | From | Last Updated |
---|---|---|
Needs to be compatible to the normal Request class. Don't know what's the best course of action here... | pprkut |
Make use of array_key_exists instead of isset to return the arguments associated to options.
Diff: |
Revision 2 (+112) |
---|
src/Lunr/Shadow/CliRequest.php (Diff revision 1) |
---|
Needs to be compatible to the normal Request class. Don't know what's the best course of action here...
inject the parser directly into the constructor of the request. for comaptibility with web request, I have no clue... the class can be still backported if it doesn't match the requirements of lunr for the coming release.
Diff: |
Revision 3 (+109) |
---|