This change has been marked as submitted.

Describe the submission (optional):

Summary:

[Lunr.Locator] Tests: Stop treating parameter getType as string

Review Request #868 — Created Sept. 14, 2022 and submitted 2 years, 7 months ago

Description

Tests: Stop treating parameter getType as string

Testing Done

Issues

Description	From	Last Updated
That's a valid test though, that you're not really replacing. All we need is a PHP version specific expectExceptionMessageMatches	pprkut	2 years, 7 months ago
There are no open issues

src/Lunr/Core/Tests/ConfigServiceLocatorBaseTest.php (Diff revision 1)

The issue has been dropped. Show all issues

That's a valid test though, that you're not really replacing.

All we need is a PHP version specific expectExceptionMessageMatches

It's a valid test for PHP internals, I don't think checking if parameter types work is up to us.

Ship it!