[Lunr.Locator] Tests: Stop treating parameter getType as string

Review Request #868 — Created Sept. 14, 2022 and submitted Sept. 16, 2022, 11:33 a.m.

Description

Tests: Stop treating parameter getType as string

Testing Done

CI at https://github.com/M2mobi/lunr.locator/pull/5

Issues

Description	From	Last Updated
That's a valid test though, that you're not really replacing. All we need is a PHP version specific expectExceptionMessageMatches	pprkut	Sept. 16, 2022, 10:40 a.m.

src/Lunr/Core/Tests/ConfigServiceLocatorBaseTest.php (Diff revision 1)

Show all issues

That's a valid test though, that you're not really replacing.

All we need is a PHP version specific expectExceptionMessageMatches

It's a valid test for PHP internals, I don't think checking if parameter types work is up to us.

Ship it!

You have a pending review.