[Lunr.Locator] Composer: Define PSR-11 compatibility correctly

Review Request #864 — Created Aug. 25, 2022 and submitted

smillernl
Lunr.Locator
chore/composer/define_container_implementation
868
lunr

Composer: Define PSR-11 compatibility correctly

Accompanies https://github.com/M2mobi/lunr.locator/pull/1



  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
pprkut
  1. 
      
  2. composer.json (Diff revision 1)
     
     

    no range?

    1. I'd prefer to have dependabot keep track of that.

    2. Why?

    3. Because it'll notify us when there are changes and then we can evaluate if we still abide by those changes.
      For PHPUnit a range is fine since it'll just fail if it gets too new, for our adherence to a protocol I think we need to be a little more strict.

    4. But it's not a protocol, it's just an interface. I don't see why different rules should apply here compared to another library we're using. IMHO, using 2.0.3 or 2.0.4 instead of 2.0.2 should be perfectly fine.

  3. 
      
smillernl
pprkut
  1. Ship It!
  2. 
      
smillernl
Review request changed

Status: Closed (submitted)

Loading...