[Gravity] add SQLiteDMLQueryBuilder class
Review Request #86 — Created April 22, 2013 and discarded
Information | |
---|---|
olivier | |
Lunr | |
https://github.com/owizen/lunr/tree/SQLiteBuilder | |
14955 | |
Reviewers | |
lunr | |
Here is the query builder for SQLite. This review depends on http://reviews.lunr.nl/r/83/ Note the following points concerning not supported features in SQLite compared to MySQL: -REPLACE statement is an alias of INSERT OR REPLACE statement -As a consequence there is no replace mode -There is no DELETE modes -Specifying a charset is not supported As a consequence, the get_insert_query and get_replace_query from the abstract class have been overriden. The index_hint method has been rewritten, have a look at it. The property $location_delimiter has been introduced and implemented as well in MySQLDMLQueryBuilder
Unit tests
Change Summary:
Add the MySQL location delimiter as default delimiter in DatabaseDMLQueryBuilder. For unit test purpose
Diff: |
Revision 2 (+796 -6) |
---|
Change Summary:
Unit tests from Dinos. This includes the SQLiteConnection. Dependencies are not relevant as long no other update for SQLiteConnection and SQLiteQueryResult are provided
Status: Re-opened
Testing Done: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+2720 -2)
|
Change Summary:
Properly rediffed
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+2720 -2)
|