- Download Diff

Summary:

[Shadow] PHPCS fixes

Review Request #857 — Created Aug. 1, 2022 and submitted Aug. 12, 2022, 10:40 a.m.

Information
Owner:	d.cova
Repository:	Lunr
Branch:	cs-shadow
Bugs:
Depends On:
Commit:	d49a5f7...
Reviewers
Groups:	lunr
People:

Description

Shadow: style formatting according to the lunr code standard

Testing Done

Issues

0
0
3
0
All Issues: 3

Description	From	Last Updated
That should not happen, it's not the String class.	smillernl	Aug. 1, 2022, 5:47 p.m.
ehhh... no?	smillernl	Aug. 1, 2022, 5:47 p.m.
Why?	smillernl	Aug. 2, 2022, 10:53 a.m.

src/Lunr/Shadow/Console.php (Diff revision 1)

Show all issues

That should not happen, it's not the String class.

src/Lunr/Shadow/GetoptCliParser.php (Diff revision 1)
Show all issues
```
ehhh... no?
```

Change Summary:

Reverts back nonsensical changes

Summary:

-	[Shadow] Style formatting according to the lunr code standard
+	[Shadow] PHPCS fixes

Commit:

-	2f643e7a875289c930e350d6f25bf022f6392a15
+	f82fffd4a632c6370e9b4a816fb468a71681cd5e

Diff:

Revision 2 (+7 -6)

Show changes

	.github/workflows/php-tests.yml
	src/Lunr/Shadow/Console.php
	src/Lunr/Shadow/GetoptCliParser.php
	src/Lunr/Shadow/LunrCliParser.php
	src/Lunr/Shadow/Tests/ConsoleTest.php

.github/workflows/php-tests.yml (Diff revision 2)
Show all issues
```
Why?
```

Change Summary:

Rebased to master

Commit:

-	f82fffd4a632c6370e9b4a816fb468a71681cd5e
+	d49a5f75dc9328ee9ad7c3d64dc79336a1407915

Diff:

Revision 3 (+5 -4)

Show changes

	src/Lunr/Shadow/Console.php
	src/Lunr/Shadow/GetoptCliParser.php
	src/Lunr/Shadow/LunrCliParser.php
	src/Lunr/Shadow/Tests/ConsoleTest.php

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

[Shadow] PHPCS fixes

Change Summary:

Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)

Change Summary: