[Gravity] Style Formatting according to the Lunr code standard

Review Request #853 — Created July 7, 2022 and submitted

d.cova
Lunr
cs-gravity
64285ad...
lunr
Style Formatting according to the Lunr code standard

Ran unit tests

  • 0
  • 0
  • 16
  • 0
  • 16
Description From Last Updated
smillernl
  1. 
      
  2. It's easier to just add use \Lunr\Core\Configuration; on top

  3. Technically 2022, AFAIK you can't backdate copyright.

  4. Technically 2022, AFAIK you can't backdate copyright.

  5. 
      
d.cova
smillernl
  1. 
      
  2. src/Lunr/Gravity/Database/DatabaseConnection.php (Diff revision 2)
     
     
     
     
     
     
     
     

    You don't need the full path if you use

  3. You don't need the full path if you use

  4. You don't need the full path if you use

  5. Not a string

            $operators   = [];
            $operators[] = [ NULL ];
            $operators[] = [ 'ALL' ];
            $operators[] = [ 'DISTINCT' ];
            $operators[] = [ TRUE ];
            $operators[] = [ FALSE ];
    
  6. Not a string

            $operators   = [];
            $operators[] = [ NULL ];
            $operators[] = [ 'ALL' ];
            $operators[] = [ 'DISTINCT' ];
            $operators[] = [ TRUE ];
            $operators[] = [ FALSE ];
    
  7. 
      
d.cova
smillernl
  1. Ship It!
  2. 
      
pprkut
  1. 
      
  2. src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 3)
     
     
     
     
     
     

    That's fixing the problem on the wrong end. Rather, the interface should be fixed to default to TRUE (that's what the implementations do)

  3. Check commit log for date of first commit

  4. Check commit log for date of first commit

  5. Typo in the first year, but this also wasn't introduced in 2012. Check the git log for the date of the first commit :)

  6. 
      
d.cova
pprkut
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...