[Gravity] Style Formatting according to the Lunr code standard

Review Request #853 — Created July 7, 2022 and submitted

d.cova
Lunr
cs-gravity
64285ad...
lunr
Style Formatting according to the Lunr code standard

Ran unit tests

  • 0
  • 0
  • 16
  • 0
  • 16
Description From Last Updated
There are no open issues
smillernl
  1. 
      
  2. The issue has been resolved. Show all issues

    It's easier to just add use \Lunr\Core\Configuration; on top

  3. The issue has been resolved. Show all issues

    Technically 2022, AFAIK you can't backdate copyright.

  4. The issue has been resolved. Show all issues

    Why?

  5. The issue has been resolved. Show all issues

    string|null

  6. The issue has been resolved. Show all issues

    Technically 2022, AFAIK you can't backdate copyright.

  7. 
      
d.cova
smillernl
  1. 
      
  2. src/Lunr/Gravity/Database/DatabaseConnection.php (Diff revision 2)
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    You don't need the full path if you use

  3. The issue has been resolved. Show all issues

    You don't need the full path if you use

  4. The issue has been resolved. Show all issues

    You don't need the full path if you use

  5. The issue has been resolved. Show all issues

    Not a string

            $operators   = [];
            $operators[] = [ NULL ];
            $operators[] = [ 'ALL' ];
            $operators[] = [ 'DISTINCT' ];
            $operators[] = [ TRUE ];
            $operators[] = [ FALSE ];
    
  6. The issue has been resolved. Show all issues

    Not a string

            $operators   = [];
            $operators[] = [ NULL ];
            $operators[] = [ 'ALL' ];
            $operators[] = [ 'DISTINCT' ];
            $operators[] = [ TRUE ];
            $operators[] = [ FALSE ];
    
  7. The issue has been resolved. Show all issues

    string|bool|null

  8. The issue has been resolved. Show all issues

    string|int|bool

  9. 
      
d.cova
smillernl
  1. Ship It!
  2. 
      
pprkut
  1. 
      
  2. src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 3)
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    That's fixing the problem on the wrong end. Rather, the interface should be fixed to default to TRUE (that's what the implementations do)

  3. The issue has been resolved. Show all issues

    Check commit log for date of first commit

  4. The issue has been resolved. Show all issues

    Check commit log for date of first commit

  5. The issue has been resolved. Show all issues

    Typo in the first year, but this also wasn't introduced in 2012. Check the git log for the date of the first commit :)

  6. 
      
d.cova
pprkut
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...