[Lunr] L10n: Standard Style fixes and shorthand notation for unit test

Review Request #850 — Created July 7, 2022 and submitted

d.cova
Lunr
cs-l10n
545849c...
lunr

Standard Style fixes and shorthand notation for unit test

Unit tests

  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
There are no open issues
smillernl
  1. 
      
  2. The issue has been resolved. Show all issues

    Can you also format the review according to our standard then?

  3. 
      
d.cova
smillernl
  1. 
      
  2. src/Lunr/L10n/Tests/L10nTraitTest.php (Diff revision 1)
     
     
    The issue has been resolved. Show all issues

    Why public?

  3. The issue has been resolved. Show all issues

    wouldn't protected work?

  4. 
      
d.cova
smillernl
  1. Ship It!
  2. 
      
pprkut
  1. 
      
  2. src/Lunr/L10n/Tests/L10nTraitTest.php (Diff revision 2)
     
     
     
    The issue has been resolved. Show all issues

    This stays

  3. src/Lunr/L10n/Tests/PHPL10nProviderTest.php (Diff revision 2)
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    This too

  4. 
      
d.cova
pprkut
  1. 
      
  2. src/Lunr/L10n/L10nHTMLView.php (Diff revision 3)
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    not a param

  3. src/Lunr/L10n/L10nProvider.php (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    not a param

  4. 
      
d.cova
d.cova
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (246c697)
Loading...