- Download Diff

Summary:

[Lunr] L10n: Standard Style fixes and shorthand notation for unit test

Review Request #850 — Created July 7, 2022 and submitted Dec. 7, 2022, 1:19 p.m.

Information
Owner:	d.cova
Repository:	Lunr
Branch:	cs-l10n
Bugs:
Depends On:
Commit:	545849c...
Reviewers
Groups:	lunr
People:

Description

Standard Style fixes and shorthand notation for unit test

Testing Done

Unit tests

Issues

0
0
7
0
All Issues: 7

Description	From	Last Updated
Can you also format the review according to our standard then?	smillernl	July 7, 2022, 11:28 a.m.
Why public?	smillernl	July 7, 2022, 12:12 p.m.
wouldn't protected work?	smillernl	July 7, 2022, 12:12 p.m.
This stays	pprkut	July 28, 2022, 5:58 p.m.
This too	pprkut	July 28, 2022, 5:58 p.m.
not a param	pprkut	Nov. 18, 2022, 10:24 a.m.
not a param	pprkut	Nov. 18, 2022, 10:23 a.m.

Show all issues

Can you also format the review according to our standard then?

Change Summary:

Changes summary and description

Summary:

-	L10n Style: Formatting according to the lunr code standard
+	[L10n] Style Formatting according to the Lunr code standard

Description:

~		L10n Style: Formatting according to the lunr code standard
	~	[L10n] Style Formatting according to the Lunr code standard

Branch:

+	cs-l10n

src/Lunr/L10n/Tests/L10nTraitTest.php (Diff revision 1)
Show all issues
```
Why public?
```
src/Lunr/L10n/Tests/PHPL10nProviderTest.php (Diff revision 1)
Show all issues
```
wouldn't protected work?
```

Change Summary:

Improved constant visibility

Testing Done:

Unit tests

Commit:

-	d823846d517646963e657c22a244c739db4b79df
+	f409b18ec8fb27920d0c1ac6caadbec1b400ed18

Diff:

Revision 2 (+8 -13)

Show changes

	src/Lunr/L10n/GettextL10nProvider.php
	src/Lunr/L10n/Tests/GettextL10nProviderTest.php
	src/Lunr/L10n/Tests/L10nProviderTest.php
	src/Lunr/L10n/Tests/L10nTraitTest.php
	src/Lunr/L10n/Tests/PHPL10nProviderTest.php

Ship it!

```
Ship It!
```

src/Lunr/L10n/Tests/L10nTraitTest.php (Diff revision 2)
Show all issues
```
This stays
```
src/Lunr/L10n/Tests/PHPL10nProviderTest.php (Diff revision 2)
Show all issues
```
This too
```

Change Summary:

Adds php ending tags

Commit:

-	f409b18ec8fb27920d0c1ac6caadbec1b400ed18
+	f42f9e2d43d246ae0a739f05ac6e291e8dc4b2fe

Diff:

Revision 3 (+23 -23)

Show changes

	src/Lunr/L10n/GettextL10nProvider.php
	src/Lunr/L10n/L10n.php
	src/Lunr/L10n/L10nHTMLView.php
	src/Lunr/L10n/L10nProvider.php
	src/Lunr/L10n/PHPL10nProvider.php
	src/Lunr/L10n/Tests/GettextL10nProviderTest.php
	src/Lunr/L10n/Tests/L10nProviderTest.php
	src/Lunr/L10n/Tests/L10nTraitTest.php
	1 more

src/Lunr/L10n/L10nHTMLView.php (Diff revision 3)
Show all issues
```
not a param
```

src/Lunr/L10n/L10nProvider.php (Diff revision 3)

Show all issues

not a param

Change Summary:


Adds use imports
Shorthand notation in unit tests

Summary:

-	[L10n] Style Formatting according to the Lunr code standard
+	[Lunr] L10n: Standard Style fixes and shorthand notation for unit test

Description:

~		[L10n] Style Formatting according to the Lunr code standard
	~	Standard Style fixes and shorthand notation for unit test

Commit:

-	f42f9e2d43d246ae0a739f05ac6e291e8dc4b2fe
+	545849c7361bd0b7b648dccbe2aad3279d92284c

Diff:

Revision 4 (+28 -15)

Show changes

	src/Lunr/L10n/GettextL10nProvider.php
	src/Lunr/L10n/L10n.php
	src/Lunr/L10n/L10nHTMLView.php
	src/Lunr/L10n/L10nProvider.php
	src/Lunr/L10n/L10nTrait.php
	src/Lunr/L10n/PHPL10nProvider.php
	src/Lunr/L10n/Tests/GettextL10nProviderTest.php
	src/Lunr/L10n/Tests/L10nBaseTest.php
	3 more

Status: Closed (submitted)

Change Summary:

Pushed to master (246c697)

You have a pending review.

Review Board 3.0.24

[Lunr] L10n: Standard Style fixes and shorthand notation for unit test

Change Summary:

Summary:

Description:

Branch:

Change Summary:

Testing Done:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Summary:

Description:

Commit:

Diff:

Status: Closed (submitted)

Change Summary: