- Download Diff

Summary:

[DataAccess][RFC] add SQLiteQueryResult class

Review Request #84 — Created April 16, 2013 and discarded Sept. 16, 2016, 2:17 p.m.

Information
Owner:	olivier
Repository:	Lunr
Branch:	https://github.com/owizen/lunr/tree/SQLiteQueryResult
Bugs:	14955
Depends On:
Reviewers
Groups:	lunr
People:

Description

This is a proposal for the SQLiteQueryResult
this review depends on 
http://reviews.lunr.nl/r/83/

Testing Done

Issues

3
0
2
0
All Issues: 5

Description	From	Last Updated
is_object, unless you are absolutely certain you won't need a composite mock	pprkut	April 18, 2013, 5:24 p.m.
number of rows is not number of columns	pprkut	April 18, 2013, 5:25 p.m.
missing unsets	pprkut	April 18, 2013, 5:48 p.m.
Documentation is scarce, you need to make sure that is has an expected behavior also for select queries.	pprkut	April 18, 2013, 5:48 p.m.
needs to return something reasonable	pprkut	April 18, 2013, 5:48 p.m.

Please rebase on top of http://reviews.lunr.nl/r/77/

Change Summary:

rebased against pprkut/gravity

Diff:

Revision 2 (+233)

Show changes

src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php

src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 2)
Show all issues
```
is_object, unless you are absolutely certain you won't need a composite mock
```
1. olivier April 18, 2013, 5:25 p.m.
  Well seen

src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 2)

Show all issues

number of rows is not number of columns

olivier April 18, 2013, 5:25 p.m.

Stupid from me plus there is not such function provided by SQLite3...

pprkut April 18, 2013, 5:42 p.m.

correct, you have to get the number of result rows from counting the result set you get. (In an efficient manner)

Change Summary:

add forgotten retrieveable informations:

$error_message;
$error_number;
$insert_id;
$affected_rows;

remark: there is no support for the number of rows retrieved from the db, the method num_rows returns then NULL...

Diff:

Revision 3 (+289 -3)

Show changes

	src/Lunr/Gravity/Database/SQLite/SQLiteConnection.php
	src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php

Change Summary:

Properly rebased against parent branch

Diff:

Revision 4 (+289 -3)

Show changes

	src/Lunr/Gravity/Database/SQLite/SQLiteConnection.php
	src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php

Fix it!

src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 3)
Show all issues
```
missing unsets
```

src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 3)

Show all issues

Documentation is scarce, you need to make sure that is has an expected behavior also for select queries.

src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 3)
Show all issues
```
needs to return something reasonable
```

This can be discarded since commit d93f341f9eebeb19915ee5aceeddfec4c91611d8 is merged

Status: Discarded

Change Summary:

Redundant

You have a pending review.

Review Board 3.0.24

[DataAccess][RFC] add SQLiteQueryResult class

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Status: Discarded

Change Summary: