[DataAccess][RFC] add SQLiteQueryResult class
Review Request #84 — Created April 16, 2013 and discarded
| Information | |
|---|---|
| olivier | |
| Lunr | |
| https://github.com/owizen/lunr/tree/SQLiteQueryResult | |
| 14955 | |
| Reviewers | |
| lunr | |
This is a proposal for the SQLiteQueryResult this review depends on http://reviews.lunr.nl/r/83/
pprkut
-
-
src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 2) is_object, unless you are absolutely certain you won't need a composite mock
-
src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 2) number of rows is not number of columns
Change Summary:
add forgotten retrieveable informations: $error_message; $error_number; $insert_id; $affected_rows; remark: there is no support for the number of rows retrieved from the db, the method num_rows returns then NULL...
Diff: |
Revision 3 (+289 -3) |
|---|
-
-
-
src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 3) Documentation is scarce, you need to make sure that is has an expected behavior also for select queries.
-
src/Lunr/Gravity/Database/SQLite/SQLiteQueryResult.php (Diff revision 3) needs to return something reasonable
