Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.
Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.
Review Request #839 — Created June 8, 2022 and submitted June 15, 2022, 1:36 p.m.
Add typehints to the main Locator class
Unit tests
shouldn't this be class|null then?
class|null
Covariance and Contravariance keeps tripping me up. It's covariance for return types, so we can be more specific than the php documentation. I will change it.
normally we do object|null in comments
object|null
I figured phpdoc would support ?, but after checking I don't see it :-/
?
Fix nullable types
Revision 2 (+83 -42)
Show changes
Ship It!
Merged into master
smillernl
