[Lunr.Locator] Core: Add PHPStan extension for ServiceLocator

Review Request #829 — Created May 5, 2022 and submitted July 14, 2022, 2:42 p.m.

Information
Owner:	smillernl
Repository:	Lunr.Locator
Branch:	feature/core/phpstan_locator
Bugs:	MM-5
Depends On:
Reviewers
Groups:	lunr
People:

Description

Core: Add PHPStan extension for ServiceLocator

Testing Done

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
Would a leading \ matter/be possible here?	pprkut	June 23, 2022, 4:32 p.m.
This may be too naive. config works, but request depends on override() being called before.	pprkut	June 23, 2022, 4:30 p.m.

src/Lunr/Core/PHPStan/ConfigServiceLocatorRecipeReflectionExtension.php (Diff revision 1)
Show all issues
```
Would a leading \ matter/be possible here?
```

src/Lunr/Core/PHPStan/ConfigServiceLocatorRecipeReflectionExtension.php (Diff revision 1)

Show all issues

This may be too naive. config works, but request depends on override() being called before.

smillernl June 23, 2022, 1:02 p.m.

I think as a general rule request also works. I can remove it, but you'll be left with a bunch of errors.

pprkut June 23, 2022, 1:58 p.m.

But that's a general rule for /us/, not for any user of Lunr.Locator. We would have to make it a configurable option, where you could provide a list of identifiers that are allowed even though the recipe is missing.

Diff:

Revision 2 (+248)

Show changes

	src/Lunr/Core/PHPStan/ConfigServiceLocatorRecipeReflection.php
	src/Lunr/Core/PHPStan/ConfigServiceLocatorRecipeReflectionExtension.php

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.24

[Lunr.Locator] Core: Add PHPStan extension for ServiceLocator

Diff:

Status: Closed (submitted)