[Gravity] Added support for EXCEPT and INTERSECT compound queries

Review Request #825 — Created April 19, 2022 and submitted

d.cova
Lunr
ML-787
822
d7b811a...
lunr
Added support for EXCEPT and INTERSECT compound queries

Unit tests

  • 0
  • 0
  • 13
  • 0
  • 13
Description From Last Updated
pprkut
  1. 
      
  2. src/Lunr/Gravity/Database/SQLDMLQueryBuilder.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Adding it in the SQLDMLQueryBuilder means the MySQLDMLQueryBuilder will have them too, which will result in broken queries if used.

    This really needs to go into MariaDB/SQLite specific query builders.

  3. 
      
d.cova
d.cova
d.cova
pprkut
  1. 
      
  2. Branch information is missing

  3. src/Lunr/Gravity/Database/MariaDB/Tests/MariaDBDMLQueryBuilderSelectTest.php (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    This needs to test more than just this. You're not verifying the query part construction here at all.

  4. src/Lunr/Gravity/Database/MySQL/MySQLSimpleDMLQueryBuilder.php (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    This should go to https://reviews.lunr.nl/r/822/, doesn't really belong here.

    1. I reverted to what it was previously now

  5. src/Lunr/Gravity/Database/SQLite3/Tests/SQLite3DMLQueryBuilderSelectTest.php (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    This also needs to test query part construction

  6. Actually this would be union() as it refers to the PHP method, not the SQL keyword.

  7. 
      
d.cova
d.cova
pprkut
  1. 
      
  2. src/Lunr/Gravity/Database/DMLQueryBuilderInterface.php (Diff revision 5)
     
     
     
     
     
     
     
     

    Change already in https://reviews.lunr.nl/r/822/

  3. src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php (Diff revision 5)
     
     
     
     
     
     
     
     
     
     
     
     

    Not used, and not needed either

  4. src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php (Diff revision 5)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Change already in https://reviews.lunr.nl/r/822/

  5. src/Lunr/Gravity/Database/MariaDB/MariaDBDMLQueryBuilder.php (Diff revision 5)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    The auto-escaping counterparts are missing

  6. src/Lunr/Gravity/Database/SQLDMLQueryBuilder.php (Diff revision 5)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Change already in https://reviews.lunr.nl/r/822/

  7. 
      
d.cova
d.cova
pprkut
  1. 
      
  2. 
      
pprkut
pprkut
d.cova
d.cova
pprkut
d.cova
d.cova
d.cova
pprkut
pprkut
pprkut
pprkut
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...