pprkut
-
-
src/Lunr/Gravity/Database/SQLDMLQueryBuilder.php (Diff revision 1) Adding it in the SQLDMLQueryBuilder means the MySQLDMLQueryBuilder will have them too, which will result in broken queries if used.
This really needs to go into MariaDB/SQLite specific query builders.
Change Summary:
Removed intersect and except methods from MySQLSimpleDMLQueryBuilder as it's unsupported
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+528 -41) |
Change Summary:
Removed references to except and intersect on SQLDMLQueryBuilder so they're not accessible to mysql
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+301 -42) |
Change Summary:
Rebased code to remove unrelated changes
-
-
-
This needs to test more than just this. You're not verifying the query part construction here at all.
-
src/Lunr/Gravity/Database/MySQL/MySQLSimpleDMLQueryBuilder.php (Diff revision 4) This should go to https://reviews.lunr.nl/r/822/, doesn't really belong here.
-
-
src/Lunr/Gravity/Database/Tests/SQLDMLQueryBuilderSelectTest.php (Diff revision 4) Actually this would be
union()as it refers to the PHP method, not the SQL keyword.
Change Summary:
Added unit test to test sqlite3 and mariadb against intersect and except
Commit: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+445 -32)
|
-
-
src/Lunr/Gravity/Database/DMLQueryBuilderInterface.php (Diff revision 5) Change already in https://reviews.lunr.nl/r/822/
-
src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php (Diff revision 5) Not used, and not needed either
-
src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php (Diff revision 5) Change already in https://reviews.lunr.nl/r/822/
-
src/Lunr/Gravity/Database/MariaDB/MariaDBDMLQueryBuilder.php (Diff revision 5) The auto-escaping counterparts are missing
-
src/Lunr/Gravity/Database/SQLDMLQueryBuilder.php (Diff revision 5) Change already in https://reviews.lunr.nl/r/822/
Change Summary:
Added tests for the maria db simple query builder
Summary: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||
Diff: |
Revision 6 (+736 -36)
|
Change Summary:
Removed files that belonged to a different review. Changed summary.
Summary: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Bugs: |
|
||||||||||||||||||
Depends On: |
|
||||||||||||||||||
Diff: |
Revision 7 (+446 -3)
|
-
-
src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php (Diff revision 7) wrong return type
-
src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php (Diff revision 7) wrong return type
Change Summary:
Changed return type and fixed some phpcs issues
Commit: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 8 (+457 -8)
|
Change Summary:
Changed return type
Commit: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 9 (+457 -8)
|
Change Summary:
removes bugs and depends on from the information
Depends On: |
|
|---|