This change has been marked as submitted.

Describe the submission (optional):

Summary:

[Lunr.Config] General: PHP 8.x compatibility

Review Request #821 — Created Feb. 15, 2022 and submitted 2 years, 10 months ago

Description

General: PHP 8.x compatibility

Testing Done

Issues

Description	From	Last Updated
Composer changes conflict with https://reviews.lunr.nl/r/754/	pprkut	2 years, 10 months ago
No?	pprkut	3 years ago
I still don't get why this is needed. There's no difference between not specifying a return type and : mixed...	pprkut	2 years, 11 months ago
There are no open issues

composer.json (Diff revision 1)

The issue has been resolved. Show all issues

No?

If we do this it will be AFAIK, since it has types in 8.0 but not in 7.x

Well then we can't. Removing support for PHP 7 isn't in the cards right now.

Revision 2 (+145 -134)

	composer.lock
	composer.json
	src/Lunr/Core/Configuration.php

The issue has been resolved. Show all issues

Composer changes conflict with https://reviews.lunr.nl/r/754/

I'll rebase the remaining change whenever one is merged

src/Lunr/Core/Configuration.php (Diff revision 2)

The issue has been dropped. Show all issues

I still don't get why this is needed. There's no difference between not specifying a return type and : mixed...

Because in 8.x the base class does have the return type, so omitting it means it's incompatible with the interface.

Ship it!