[Gravity] Add table escaping in MySQLSimpleDMLQueryBuilder::delete

Review Request #816 — Created Nov. 12, 2021 and submitted

b.stoop
Lunr
simpledmlbuilder/delete
b97d479...
lunr

Add table escaping in MySQLSimpleDMLQueryBuilder::delete

unit test and local tests

  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
smillernl
  1. Ship It!
  2. 
      
pprkut
  1. 
      
  2. src/Lunr/Gravity/Database/MySQL/MySQLSimpleDMLQueryBuilder.php (Diff revision 1)
     
     
     
     
     
     
     
     
     

    That's because delete doesn't take columns, it says so in the phpdoc. $delete are table references.

  3. 
      
b.stoop
pprkut
  1. Ship It!
  2. 
      
pprkut
  1. 
      
  2. I just noticed we don't actually do a trim anywhere. Can you just make sure it actually behaves like this?

    1. It actually does get trimmed in https://git.m2mobi.com/projects/MMW/repos/lunr/browse/src/Lunr/Gravity/Database/DatabaseQueryEscaper.php#234

    2. Indeed! Thanks for checking :)

  3. 
      
b.stoop
pprkut
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...