[Vortex] Raw JPush payload should be passed as string

Review Request #812 — Created Oct. 25, 2021 and submitted

pprkut
Lunr.Vortex
88852ca...
lunr
This makes JPush consistent with APNS and FCM.

Unit tests

  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
smillernl
  1. 
      
  2. It makes it consistent in a way that we did not want to have. We wanted to use arrays for APNS and FCM instead of going string->array->string->array throughout the code

    1. That's a different flow :)

      The payload passed here is the actual payload, not some abstraction. It's supposed to be the value we used in the dispatcher for $this->http->post() (in the case of JPush), for potential logging purposes.

      The flow you mean is when we pass the payload objects to the push() method of the dispatcher. That should indeed not be a string.

  3. 
      
smillernl
  1. Ship It!
  2. 
      
pprkut
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...