[Gravity] Add support for functions is the select query

Review Request #801 — Created Oct. 18, 2021 and discarded

b.stoop
Lunr
gravity/functionsupport
lunr

Add support for functions is the select query

local tests and unit test

  • 3
  • 0
  • 0
  • 0
  • 3
Description From Last Updated
So... about those unittests huh smillernl smillernl
Sorry, no. I'm going to veto this. Functions are just too difficult to escape properly. It's impossible to know whether ... pprkut pprkut
This is not really secure after i think about it b.stoop b.stoop
b.stoop
smillernl
  1. 
      
  2. So... about those unittests huh

  3. 
      
b.stoop
b.stoop
  1. 
      
  2. This is not really secure after i think about it

  3. 
      
pprkut
  1. 
      
  2. Sorry, no. I'm going to veto this.

    Functions are just too difficult to escape properly. It's impossible to know whether the arguments are column names, strings, tables, or something else entirely, and the logic would need to differ for every function.

    If you need functions in the select statement, use the normal query builder (not the simple one), and do the escaping yourself.

  3. 
      
b.stoop
Review request changed

Status: Discarded

Loading...