-
-
src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 1) You can still use $context here.
Something like
{query}; had {warning_count} warnings: -
src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 1) Please move this out of the
has_failed()check -
src/Lunr/Gravity/Database/DatabaseQueryResultInterface.php (Diff revision 1) Separate review please :)
-
-
src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 2) Minor optimization:
$warnings = $query->warnings();
and then:
if ($warnings !== NULL)... foreach ($warnings as ... count($warnings)...
-
src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 2) I don't think putting the warnings into context is the most elegant solution here.
At the very least, every warning should appear on a new line, so not separated by;. -
Change Summary:
Processed feedback
Commit: |
|
||
|---|---|---|---|
Diff: |
Revision 3 (+74) |
-
-
src/Lunr/Gravity/Database/DatabaseAccessObject.php (Diff revision 3) You can already define the
{query}; had ...string here. Saves a string concat later
Change Summary:
fixed string concat
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+74) |
