pprkut
Summary: |
|
|---|
[Lunr.Vortex] General: Update ApnsPHP to master branch
Review Request #757 — Created April 6, 2021 and submitted
| Information | |
|---|---|
| m.vanberkum | |
| Lunr.Vortex | |
| fix/ApnsPHPVersion | |
| 2606d9f... | |
| Reviewers | |
| lunr | |
Update ApnsPHP to master branch
Unit tests.
-
-
src/Lunr/Vortex/APNS/ApnsPHP/APNSDispatcher.php (Diff revision 1) Why not \ApnsPHP\Message\Exception?
-
src/Lunr/Vortex/APNS/ApnsPHP/APNSDispatcher.php (Diff revision 1) Why that rename? \ApnsPHP\Exception would have been fine
-
src/Lunr/Vortex/APNS/ApnsPHP/APNSDispatcher.php (Diff revision 1) Absolute Path please. Relative path only for classes in the same folder.
Change Summary:
Changed paths
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+43 -37) |
Change Summary:
Updated paths
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+43 -37) |
-
-
src/Lunr/Vortex/APNS/ApnsPHP/APNSDispatcher.php (Diff revision 3) I think for consistency we should probably alias this as ApnsException ot ApnsPHPException or some such.
-
Change Summary:
Exception alias
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+43 -37) |
