Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Summary:

[Lunr.Halo] CI: Move to GitHub actions

Review Request #753 — Created March 19, 2021 and submitted July 16, 2021, 9:55 a.m.

Information
Owner:	smillernl
Repository:	Lunr.Halo
Branch:	github_actions
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

CI: Move to GitHub actions

Testing Done

Issues

1
0
1
0
All Issues: 2

Description	From	Last Updated
PHPStan currently fails on the UOPZ calls since someone added the signature incorrectly. Gonna wait to merge this.	smillernl	May 19, 2021, 2:01 p.m.
Why do we need this? Any place should use either or, with a preference for composer.	pprkut	March 27, 2021, 4:56 p.m.

.github/workflows/php-tests.yml (Diff revision 1)

Show all issues

Why do we need this?

Any place should use either or, with a preference for composer.

smillernl March 24, 2021, 8:47 a.m.

Because phpstan can only use one and it is using decomposer.

pprkut March 24, 2021, 9:58 a.m.

We just need a different bootstrap file, like we have for phpunit. Or does that not work here?

smillernl March 24, 2021, 2:14 p.m.

It can work here. The phpunit one might actually work here. I just decided to only edit the actions workflow.

Diff:

Revision 2 (+62 -25)

	.travis.yml
	composer.json
	.github/dependabot.yml
	.github/workflows/php-tests.yml
	tests/phpstan.neon.dist

Ship it!

```
Ship It!
```

Fix it!

Show all issues

PHPStan currently fails on the UOPZ calls since someone added the signature incorrectly. Gonna wait to merge this.

Status: Closed (submitted)

Loading...