[Vortex] General: Add types

Review Request #742 — Created March 10, 2021 and discarded

smillernl
Lunr.Vortex
feature/general/types
765
lunr

General: Add types



  • 1
  • 0
  • 21
  • 2
  • 24
Description From Last Updated
Sorry, I'm getting lost in this review. Can we split it up into one review per platform? pprkut pprkut
pprkut
  1. 
      
  2. src/Lunr/Vortex/APNS/APNSPayload.php (Diff revision 1)
     
     

    no APNSPriority::* ?

  3. Can you add a use declaration for it?

  4. no root namespace indicator needed

  5. Shouldn't be needed

  6. We should be able to say APNSPayload here instead of object, and APNSResponse instead of PushNotificationResponseInterface

    1. Payloads don't extend a common class so I can't do that.

  7. We should be able to say EmailPayload here instead of object, and EmailResponse instead of PushNotificationResponseInterface

  8. src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1)
     
     

    Please add a use declaration

  9. src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1)
     
     

    We should be able to say FCMPayload here instead of object, and FCMResponse instead of PushNotificationResponseInterface

  10. Please add a use declaration

  11. Please add a use declaration

  12. Please add a use declaration

  13. We should be able to say JPushPayload here instead of object, and JPushResponse instead of PushNotificationResponseInterface

  14. src/Lunr/Vortex/MPNS/MPNSDispatcher.php (Diff revision 1)
     
     

    Please add a use declaration

  15. src/Lunr/Vortex/MPNS/MPNSDispatcher.php (Diff revision 1)
     
     

    We should be able to say MPNSPayload here instead of object, and MPNSResponse instead of PushNotificationResponseInterface

  16. src/Lunr/Vortex/MPNS/MPNSDispatcher.php (Diff revision 1)
     
     

    Please add a use declaration

  17. src/Lunr/Vortex/MPNS/MPNSResponse.php (Diff revision 1)
     
     

    Please add a use declaration

  18. src/Lunr/Vortex/MPNS/MPNSResponse.php (Diff revision 1)
     
     

    Please add a use declaration

  19. src/Lunr/Vortex/MPNS/Tests/MPNSResponseErrorTest.php (Diff revision 1)
     
     
     
     
     

    Needs updated test name

  20. src/Lunr/Vortex/PAP/PAPDispatcher.php (Diff revision 1)
     
     

    We should be able to say PAPPayload here instead of object, and PAPResponse instead of PushNotificationResponseInterface

  21. src/Lunr/Vortex/PAP/PAPResponse.php (Diff revision 1)
     
     

    Please add a use declaration

  22. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 1)
     
     

    Please add a use declaration

  23. src/Lunr/Vortex/WNS/WNSDispatcher.php (Diff revision 1)
     
     

    We should be able to say WNSPayload here instead of object, and WNSResponse instead of PushNotificationResponseInterface

  24. src/Lunr/Vortex/WNS/WNSResponse.php (Diff revision 1)
     
     

    Please add a use declaration

  25. 
      
smillernl
pprkut
  1. 
      
  2. Sorry, I'm getting lost in this review. Can we split it up into one review per platform?

  3. 
      
smillernl
Review request changed

Status: Discarded

Loading...