[Vortex] CI: Add phpstan fixes

Review Request #741 — Created March 10, 2021 and submitted

smillernl
Lunr.Vortex
feature/ci/phpstan
764
lunr
CI: Add phpstan fixes


  • 0
  • 0
  • 2
  • 2
  • 4
Description From Last Updated
pprkut
  1. 
      
  2. src/Lunr/Vortex/FCM/FCMResponse.php (Diff revision 1)
     
     

    string?

    1. Yes, It's ["endpoint" => Status]

    2. Oh, it's the key type. Got it

  3. src/Lunr/Vortex/PAP/PAPPayload.php (Diff revision 1)
     
     
     
     
     
     

    I think NULL would work equally well here. Just set it in the constructor instead.

    1. I'll see if I can, I didn't want to change the working in this PR.

  4. src/Lunr/Vortex/WNS/WNSResponse.php (Diff revision 1)
     
     
     
     
     
     

    It's always gonna be Requests_Response_Headers as far as I can see

    1. Yeah, the array had me confused

  5. 
      
smillernl
pprkut
  1. Ship It!
  2. 
      
smillernl
Review request changed

Status: Closed (submitted)

Loading...