Since RETURNING can be followed by any kind of select_expr, it should support the same functionality as in sql_select().
Maybe you can think of a way to share the code? :)

You can look at sql_condition() for inspiration.
Would mean that we don't actually need a dedicated sql_returning() method after all :-/

Dont forget that MariaDBDMLQueryBuilder needs changes too

Nice! :D

I prefer to keep this in line with how sql_condition() works, so:

$base = 'SELECT'


The boolean solution isn't wrong. Using the string syntax is just more consistent with existing code.

$option might not be the best wording here. Since we're always constructing a statement that selects from the database, $select would be better.

Now that we merged the code for handling RETURNING into sql_select, you can merge the unit tests too. You can keep the separate file, just rename it to QueryPartsSelectTest and move the other tests for sql_select() to here too.

heh, nice initiative :)
I prefer to keep it $select, however. select_expr can include columns, but also function calls, scalar values, etc. So $columns would give the wrong impression here.

We can kill those. Remnant of early Lunr days. We don't do these kinds of dependencies anywhere else anymore :)

If you change this you need to make sure that the tests you now depend on also execute before. As it's currently listed in phpunit.xml, they wouldn't.

Ship It!