This change has been marked as submitted.

Describe the submission (optional):

Summary:

[Lunr] Gravity: Throw on empty table reference

Review Request #727 — Created Nov. 17, 2020 and submitted 4 years, 3 months ago

Information
Owner:	smillernl*
Repository:	Lunr
Branch:	feature/gravity/throw_on_missing_table
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Gravity: Throw on empty table reference

Testing Done

Issues

Description	From	Last Updated
I'd rather have a specific Exception here, extending from DatabaseException.	pprkut	4 years, 5 months ago
MissingTableReferenceException matching the naming to the SQL grammar	pprkut	4 years, 3 months ago
There are no open issues

src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php (Diff revision 1)
The issue has been resolved. Show all issues
```
I'd rather have a specific Exception here, extending from DatabaseException.
```

	src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php
	src/Lunr/Gravity/Database/Exceptions/MissingTableException.php
	src/Lunr/Gravity/Database/Tests/DatabaseDMLQueryBuilderGetDeleteQueryTest.php
	src/Lunr/Gravity/Database/Tests/DatabaseDMLQueryBuilderGetInsertQueryTest.php
	src/Lunr/Gravity/Database/Tests/DatabaseDMLQueryBuilderGetReplaceQueryTest.php
	src/Lunr/Gravity/Database/Tests/DatabaseDMLQueryBuilderGetUpdateQueryTest.php

mechanics are fine, just a nitpick on the naming

	src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php
	src/Lunr/Gravity/Database/Exceptions/MissingTableReferenceException.php
	src/Lunr/Gravity/Database/Tests/DatabaseDMLQueryBuilderGetDeleteQueryTest.php
	src/Lunr/Gravity/Database/Tests/DatabaseDMLQueryBuilderGetInsertQueryTest.php
	src/Lunr/Gravity/Database/Tests/DatabaseDMLQueryBuilderGetReplaceQueryTest.php
	src/Lunr/Gravity/Database/Tests/DatabaseDMLQueryBuilderGetUpdateQueryTest.php

Ship it!