[Lunr] Gravity: Indicate helper attributes as PHPunit mocks

Review Request #726 — Created Nov. 17, 2020 and discarded Dec. 3, 2020, 2:44 p.m.

Information
Owner:	smillernl
Repository:	Lunr
Branch:	feature/gravity/helper_mock_hints
Bugs:
Depends On:
Reviewers
Groups:	lunr
People:

Description

Gravity: Indicate helper attributes as PHPunit mocks

Testing Done

Issues

1
0
0
0
All Issues: 1

Description	From	Last Updated
What do we gain from this?	pprkut	Nov. 18, 2020, 7:57 a.m.

Fix it!

src/Lunr/Gravity/Database/MariaDB/Tests/Helpers/AbstractMariaDBDatabaseAccessObjectTest.php (Diff revision 1)

Show all issues

What do we gain from this?

smillernl Nov. 18, 2020, 9:48 a.m.

Better code completion in tests that use this. And more accurate typehints

pprkut Nov. 18, 2020, 10:26 a.m.

I don't want to use intersection types until PHP understands them natively. Also, "better code completion" is relative, because for me this would actually break code completion.

You have a pending review.

Review Board 3.0.24

[Lunr] Gravity: Indicate helper attributes as PHPunit mocks

Status: Closed (submitted)

Status: Re-opened

Status: Discarded