[Vortex] Add JPush message payload style

Review Request #721 — Created Oct. 23, 2020 and submitted Oct. 29, 2020, 12:36 p.m.

Information
Owner:	smillernl
Repository:	Lunr
Branch:	feature/vortex/jpush_message_payload
Bugs:	HKG-5448
Depends On:	~~718~~
Reviewers
Groups:	lunr
People:

Description

Vortex: Add JPush message payload style

Testing Done

Issues

Description	From	Last Updated
This is mixing concepts. Different payload types should be different classes.	pprkut	Oct. 28, 2020, 4:11 p.m.

src/Lunr/Vortex/JPush/JPushPayload.php (Diff revision 1)

Show all issues

This is mixing concepts. Different payload types should be different classes.

FCM doesn't have a clean split between 'notification' and 'data'. A payload could have both aspects. Here they look definitely either/or.

It could also have both. I'll change that.

Revision 2 (+792 -192)

	src/Lunr/Vortex/JPush/JPushMessagePayload.php
	src/Lunr/Vortex/JPush/JPushNotificationPayload.php
	src/Lunr/Vortex/JPush/JPushPayload.php
	src/Lunr/Vortex/JPush/Tests/JPushMessagePayloadBaseTest.php
	src/Lunr/Vortex/JPush/Tests/JPushMessagePayloadGetTest.php
	src/Lunr/Vortex/JPush/Tests/JPushMessagePayloadSetTest.php
	src/Lunr/Vortex/JPush/Tests/JPushMessagePayloadTest.php
	src/Lunr/Vortex/JPush/Tests/JPushNotificationPayloadBaseTest.php
	7 more

Ship it!

You have a pending review.