This change has been discarded.

Describe the reason it's discarded (optional):

Summary:

[Lunr] General: Add phpstan support

Review Request #702 — Created July 31, 2020 and discarded 2 years, 11 months ago

Description

General: Add phpstan support

Testing Done

Issues

Description	From	Last Updated
Mmm, no, that's not correct. $simple is an interface extension from the MySQL classes.	pprkut	4 years, 8 months ago
sqlite doesn't have simple query builder	pprkut	4 years, 8 months ago
IMHO, the passed parameter is correct, and if we have to change this, it should be added in the DAO ...	pprkut	4 years, 8 months ago

Fix it!

src/Lunr/Gravity/Database/DatabaseConnection.php (Diff revision 1)

An issue was opened. Show all issues

Mmm, no, that's not correct. $simple is an interface extension from the MySQL classes.

src/Lunr/Gravity/Database/SQLite3/SQLite3Connection.php (Diff revision 1)

An issue was opened. Show all issues

sqlite doesn't have simple query builder

src/Lunr/Sphere/DatabaseSessionHandler.php (Diff revision 1)

An issue was opened. Show all issues

IMHO, the passed parameter is correct, and if we have to change this, it should be added in the DAO instead.