[Lunr] General: Add phpstan support

Review Request #702 — Created July 31, 2020 and discarded

smillernl
Lunr
feature/phpstan
lunr
General: Add phpstan support


  • 3
  • 0
  • 0
  • 0
  • 3
Description From Last Updated
Mmm, no, that's not correct. $simple is an interface extension from the MySQL classes. pprkut pprkut
sqlite doesn't have simple query builder pprkut pprkut
IMHO, the passed parameter is correct, and if we have to change this, it should be added in the DAO ... pprkut pprkut
pprkut
  1. 
      
  2. src/Lunr/Gravity/Database/DatabaseConnection.php (Diff revision 1)
     
     
     
     
     
     
     
     
     

    Mmm, no, that's not correct. $simple is an interface extension from the MySQL classes.

  3. src/Lunr/Gravity/Database/SQLite3/SQLite3Connection.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     

    sqlite doesn't have simple query builder

  4. IMHO, the passed parameter is correct, and if we have to change this, it should be added in the DAO instead.

  5. 
      
smillernl
Review request changed

Status: Discarded

Loading...