[Vortex] JPush response check

Review Request #699 — Created July 15, 2020 and submitted

smillernl
Lunr
feature/vortex/jpush_response
HKG-1262
698
700
lunr
Vortex: JPush response check


  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
There are no open issues
smillernl
pprkut
  1. 
      
  2. src/Lunr/Vortex/JPush/JPushBatchResponse.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    we've been pretty lenient on what can be done in constructors of the response classes, but making an entire new HTTP request is taking it to far.

    I would prefer doing this on demand, triggered by the get_status() call.

  3. 
      
smillernl
pprkut
  1. 
      
  2. src/Lunr/Vortex/JPush/JPushBatchResponse.php (Diff revision 2)
     
     
     
     
     
    The issue has been dropped. Show all issues

    report_error() is called from the constructor and sets $this->statuses, so there's never a case where it's empty.

    1. Nevermind, got the logic wrong. Should be fine

  3. 
      
pprkut
  1. Ship It!
  2. 
      
smillernl
Review request changed

Status: Closed (submitted)

Loading...