Summary: |
|
---|
-
-
src/Lunr/Vortex/JPush/JPushBatchResponse.php (Diff revision 1) we've been pretty lenient on what can be done in constructors of the response classes, but making an entire new HTTP request is taking it to far.
I would prefer doing this on demand, triggered by the get_status() call.
-
-
src/Lunr/Vortex/JPush/JPushBatchResponse.php (Diff revision 2) report_error() is called from the constructor and sets $this->statuses, so there's never a case where it's empty.