Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+64 -2) |
[Corona] Throw if JSONView encoding fails
Review Request #676 — Created Aug. 28, 2019 and updated
| Information | |
|---|---|
| smillernl | |
| Lunr | |
| fix/throw_on_json_fail | |
|
|
|
| e516764... | |
| Reviewers | |
| lunr | |
Throw if JSONView encoding fails
- 1
- 0
- 1
- 0
- 2
| Description | From | Last Updated |
|---|---|---|
| Not good enough. We need to have actual test values here that trigger the actual behavior |
pprkut
|
-
-
src/Lunr/Corona/JsonView.php (Diff revision 1) InternalServerErrorException doesn't add anything here. There's no RequestResultHandler catching to it would just end up as an uncaught exception, potentially triggering print_fatal_error(), which hardcodes 500.
There's also a chance that it won't trigger print_fatal_error and only show an empty output
-
src/Lunr/Corona/Tests/JsonViewPrintTest.php (Diff revision 1) Not good enough. We need to have actual test values here that trigger the actual behavior