[General] add return types in tests

Review Request #658 — Created March 15, 2019 and submitted Dec. 11, 2019, 2:09 p.m.

Information
Owner:	smillernl
Repository:	Lunr
Branch:	phpunit8
Bugs:	ML-586
Depends On:
Reviewers
Groups:	lunr
People:

Description

Corona: add return types in tests

Gravity: add return types in tests

L10n: add return types in tests

Shadow: add return types in tests

Spark: add return types in tests

Spawn: add return types in tests

Sphere: add return types in tests

Vortex: add return types in tests

General: bump phpunit version and update EnvTest

Testing Done

Issues

0
0
6
0
All Issues: 6

Description	From	Last Updated
There were 216 errors Guess this isn't quite ready yet :-/	pprkut	Dec. 11, 2019, 2:09 p.m.
what does this do?	pprkut	Dec. 9, 2019, 10:23 a.m.
this can go	pprkut	Dec. 9, 2019, 10:23 a.m.
this can go	pprkut	Dec. 9, 2019, 10:23 a.m.
if we drop support for PHP 5, this can go	pprkut	Dec. 9, 2019, 10:23 a.m.
PHP 7.1 requires xdebug 2.5	pprkut	Dec. 9, 2019, 10:23 a.m.

Summary:

-	Core: add return types in tests
+	[General] add return types in tests

Branch:

+	phpunit8

Ship it!

composer.json (Diff revision 1)

Show all issues

what does this do?

smillernl Aug. 19, 2019, 1:49 p.m.

It accepts any version of psr/log that is already installed. basically avoiding duplication with Lunr.Halo

pprkut Dec. 5, 2019, 4:01 p.m.

From what I understand from the documentation, this is not correct. You specify that Lunr replaces Psr/Log, i.e. "if you need Psr/Log, you can use Lunr instead since it replaces it", declaring Lunr a fork of Psr/Log which is definitely not the case.

Not even the case where it includes a subpackage makes sense, since we should use self.version then and that won't work either.

composer.json (Diff revision 1)
Show all issues
```
this can go
```
composer.json (Diff revision 1)
Show all issues
```
this can go
```

composer.json (Diff revision 1)

Show all issues

if we drop support for PHP 5, this can go

composer.json (Diff revision 1)
Show all issues
```
PHP 7.1 requires xdebug 2.5
```

Show all issues

There were 216 errors

Guess this isn't quite ready yet :-/

pprkut Dec. 11, 2019, 1:13 p.m.

Most of it seems to be errors like Call to undefined method Lunr\Spark\Twitter\Tests\SearchApiTest::assertIsArray()

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

[General] add return types in tests

Summary:

Branch:

Status: Closed (submitted)

Change Summary: