Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Summary:

Gravity: Added dummy query exception for unittests.

Review Request #642 — Created Dec. 11, 2018 and submitted Jan. 30, 2019, 5:49 p.m.

Information
Owner:	p.valk
Repository:	Lunr
Branch:	ex
Bugs:
Depends On:
Commit:	9c3a97a...
Reviewers
Groups:	lunr
People:

Description

Gravity: Added dummy query exception for unittests.

Testing Done

Issues

0
0
3
0
All Issues: 3

Description	From	Last Updated
This is fine, but please make it a test helper instead of a regular exception. (By moving it to Tests/Helpers ...	pprkut	Dec. 14, 2018, 11:34 a.m.
It doesn't	smillernl	Dec. 14, 2018, 2:19 p.m.
Meh	smillernl	Dec. 14, 2018, 2:19 p.m.

src/Lunr/Gravity/Database/Exceptions/DummyQueryException.php (Diff revision 1)

Show all issues

This is fine, but please make it a test helper instead of a regular exception. (By moving it to Tests/Helpers where we also have the others)

Commit:

-	0e6a80ddda030ef0abcd01abed8f1193cddc9c29
+	20b8640c2f12aaac44288467c83a03ecb927259e

Diff:

Revision 2 (+29)

src/Lunr/Gravity/Database/Exceptions/Tests/Helpers/DummyQueryException.php

Commit:

-	20b8640c2f12aaac44288467c83a03ecb927259e
+	75db9407a4e1a19744506fa8db495b90a44bdde3

Diff:

Revision 3 (+31)

src/Lunr/Gravity/Database/Exceptions/Tests/Helpers/DummyQueryException.php

src/Lunr/Gravity/Database/Exceptions/Tests/Helpers/DummyQueryException.php (Diff revision 3)
Show all issues
```
It doesn't
```
src/Lunr/Gravity/Database/Exceptions/Tests/Helpers/DummyQueryException.php (Diff revision 3)
Show all issues
```
Meh
```

Commit:

-	75db9407a4e1a19744506fa8db495b90a44bdde3
+	9c3a97abac276420a32041416bc49c5beeb062f1

Diff:

Revision 4 (+31)

src/Lunr/Gravity/Database/Exceptions/Tests/Helpers/DummyQueryException.php

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...