[Halo] Add assert method to check for unset properties

Review Request #633 — Created Oct. 23, 2018 and submitted Oct. 24, 2018, 5:36 p.m.

Information
Owner:	pprkut
Repository:	Lunr.Halo
Branch:
Bugs:
Depends On:
Blocks:	634
Commit:	337eece...
Reviewers
Groups:	lunr
People:

Description

Add assert method to check for unset properties

Testing Done

Unit tests

Issues

0
0
1
1
All Issues: 2

Description	From	Last Updated
shouldn't this be snake_case?	smillernl	Oct. 24, 2018, 11:39 a.m.
Not sure I understand correctly all this but if I try to get what is happening here, I feel like ...	tardypad	Oct. 24, 2018, 1:23 p.m.

Commit:

-	4e92a3670e6e38fcc0d5e94ab928c660041518fd
+	678cad59ab177b9cb759073144f9a2feb599426a

Diff:

Revision 2 (+29)

Show changes

src/Lunr/Halo/LunrBaseTest.php

src/Lunr/Halo/LunrBaseTest.php (Diff revision 2)

Show all issues

shouldn't this be snake_case?

pprkut Oct. 24, 2018, 9:30 a.m.

it's like this to be in line with phpunit asserts and the existing asserts in LunrBaseTest

Ship it!

```
Ship It!
```

src/Lunr/Halo/LunrBaseTest.php (Diff revision 2)

Show all issues

Not sure I understand correctly all this but if I try to get what is happening here, I feel like using
try
{
    $property = $this->get_accessible_reflection_property($property);
    $property->getValue($this->class);
}
catch(Throwable $e)
{
    $this->assertContains("Cannot access", $e->getMessage());
}

should be enough, no?

pprkut Oct. 24, 2018, 1:05 p.m.

I had that before. Unfortunately that neither catches the (old) success case nor the expected failure