Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Summary:

[Gravity] Add geometric value escaper for MySQLQueryEscaper

Review Request #615 — Created Sept. 10, 2018 and submitted Sept. 11, 2018, 9:10 a.m.

Information
Owner:	k.woortman
Repository:	Lunr
Branch:	geo_query_escaper
Bugs:
Depends On:
Commit:	a91f849...
Reviewers
Groups:	lunr
People:

Description

Add method to the MySQLQueryEscaper for escaping geometry values.

Testing Done

Unit tests.

Issues

0
0
3
0
All Issues: 3

Description	From	Last Updated
just use $this->value()	pprkut	Sept. 10, 2018, 12:10 p.m.
there's a really nice feature for this called !is_null($var)	smillernl	Sept. 10, 2018, 12:10 p.m.
hngh, 1 space please	smillernl	Sept. 10, 2018, 12:10 p.m.

src/Lunr/Gravity/Database/MySQL/MySQLQueryEscaper.php (Diff revision 1)
Show all issues
```
there's a really nice feature for this called !is_null($var)
```
src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryEscaperEscapeTest.php (Diff revision 1)
Show all issues
```
hngh, 1 space please
```

src/Lunr/Gravity/Database/MySQL/MySQLQueryEscaper.php (Diff revision 1)
Show all issues
```
just use $this->value()
```

Change Summary:

Fix code review issues.

Commit:

-	ee837ea102b95a36808de93f84d3e157857d5d29
+	a91f8494d1614d22d406925a6df71d7cdcce5e63

Diff:

Revision 2 (+50)

	src/Lunr/Gravity/Database/MySQL/MySQLQueryEscaper.php
	src/Lunr/Gravity/Database/MySQL/Tests/MySQLQueryEscaperEscapeTest.php

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...