pprkut
Summary: |
|
|---|
[Gravity] MySQLSimpleQueryBuilder make the DMLQueryBuilder a property instead of inheritance.
Review Request #599 — Created Aug. 24, 2018 and submitted
| Information | |
|---|---|
| Mathijs | |
| Lunr | |
| feature-prep-for-mariadb | |
| 596, 606 | |
| a38ac7d... | |
| Reviewers | |
| lunr | |
[Gravity] MySQLSimpleQueryBuilder make the DMLQueryBuilder a property instead of inheritance.
Unit tests, also tested Skydive with this version as dependency.
-
-
src/Lunr/Gravity/Database/MySQL/MySQLSimpleDMLQueryBuilder.php (Diff revision 1) I'd probably flip it. The query builder is more important than the escaper
-
src/Lunr/Gravity/Database/MySQL/Tests/MySQLSimpleDMLQueryBuilderConditionalTest.php (Diff revision 1) The return type of all these methods is not 'string'. They are returning $this.
Change Summary:
Extended the DMLQueryBuilder interface. Make MySQLSimpleDMLQueryBuilder implement the DMLQueryBuilder interface. Changed return value from $this->builder to $this
Testing Done: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||
Diff: |
Revision 3 (+754 -194)
|