[Gravity] Add MariaDB connection and query builders

Review Request #596 — Created Aug. 22, 2018 and submitted

Information
Mathijs
Lunr
feature-mariadb-querybuilders
599
8e20a0f...
Reviewers
lunr 
[Gravity] Add MariaDB connection and query builders
Unit tests
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Mathijs
pprkut
pprkut 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    That's already in the parent
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    this needs updating
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




Mathijs




   

   

  

 



 















 





 

  

   




pprkut




   

   







  

 



 

  


   

   

    
 
pprkut


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Unit tests fail:
      

      

      There were 2 errors:

1) Lunr\Gravity\Database\MariaDB\Tests\MariaDBConnectionBaseTest::testGetSimpleDMLQueryBuilder
Error: Cannot access parent:: when current class scope has no parent

/mnt/progs/projects/web/lunr/src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php:33
/mnt/progs/projects/web/lunr/src/Lunr/Gravity/Database/MariaDB/MariaDBConnection.php:57
/mnt/progs/projects/web/lunr/src/Lunr/Gravity/Database/MariaDB/Tests/MariaDBConnectionBaseTest.php:46

2) Lunr\Gravity\Database\MariaDB\Tests\MariaDBSimpleDMLQueryBuilderBaseTest::testEscaperIsPassedCorrectly
Error: Cannot access parent:: when current class scope has no parent

/mnt/progs/projects/web/lunr/src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php:33
/mnt/progs/projects/web/lunr/src/Lunr/Gravity/Database/MariaDB/Tests/MariaDBSimpleDMLQueryBuilderTest.php:75

      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




Mathijs




   

   

  

 



 















 



 

  

   




Mathijs




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Merged into master





 


 










  

 









     

    

   

  

  

   
   Loading...