Summary: |
|
---|
-
-
-
src/Lunr/Gravity/Database/MariaDB/MariaDBConnection.php (Diff revision 1) if they are new then copyright should be 2018 not 2012 :P
-
src/Lunr/Gravity/Database/MariaDB/MariaDBDMLQueryBuilder.php (Diff revision 1) if they are new then copyright should be 2018 not 2012 :P
-
src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php (Diff revision 1) if they are new then copyright should be 2018 not 2012 :P
-
-
-
-
src/Lunr/Gravity/Database/MariaDB/Tests/MariaDBDMLQueryBuilderTest.php (Diff revision 1) if they are new then copyright should be 2018 not 2012 :P
-
-
src/Lunr/Gravity/Database/MariaDB/Tests/MariaDBSimpleDMLQueryBuilderDeleteTest.php (Diff revision 1) if they are new then copyright should be 2018 not 2013 :P
-
src/Lunr/Gravity/Database/MariaDB/Tests/MariaDBSimpleDMLQueryBuilderDeleteTest.php (Diff revision 1) why double??
-
src/Lunr/Gravity/Database/MariaDB/Tests/MariaDBSimpleDMLQueryBuilderDeleteTest.php (Diff revision 1) expectedReturningDataProvider
-
-
-
src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php (Diff revision 1) This misses the data type. Look at the @var boolean above.
-
src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php (Diff revision 1) $this->escaper gets set in the parent constructor as well. Choose either one.
-
src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php (Diff revision 1) unsetting $this->escaper is done in the parent destruct as well. Choose one.
-
-
tests/phpunit.xml (Diff revision 2) please add :
<directory>../src/Lunr/Gravity/Database/MariaDB/Tests/</directory>
Commit: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+532 -1)
|
-
I'd like to have the MariaDB connection / query builder classes in a separate review first, before adding delete returning functionality.
Also, the change to not have the simple query builder extend the parent query builder should be done uniformly for MySQL/SQLite in a separate review as well. -
src/Lunr/Gravity/Database/MariaDB/MariaDBDMLQueryBuilder.php (Diff revision 3) We typically call those columns
-
src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php (Diff revision 3) you escape columns and then use the unescaped original...