[Lunr] Gravity: Implement returning statement in MariaDB delete queries

Review Request #586 — Created Aug. 13, 2018 and discarded

Mathijs
Lunr
feature-mariadb
lunr
Gravity: implement returning statement in delete query

Unit tests

  • 2
  • 0
  • 17
  • 0
  • 19
Description From Last Updated
We typically call those columns pprkut pprkut
you escape columns and then use the unescaped original... pprkut pprkut
Mathijs
Mathijs
p.valk
  1. 
      
  2. src/Lunr/Gravity/Database/DatabaseDMLQueryBuilder.php (Diff revision 1)
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    missing datatype.

  3. The issue has been resolved. Show all issues

    if they are new then copyright should be 2018 not 2012 :P

  4. The issue has been resolved. Show all issues

    if they are new then copyright should be 2018 not 2012 :P

  5. The issue has been resolved. Show all issues

    if they are new then copyright should be 2018 not 2012 :P

  6. The issue has been resolved. Show all issues

    if they are new then copyright should be 2018 not 2012 :P

  7. The issue has been resolved. Show all issues

    expectedReturningDataProvider

  8. The issue has been resolved. Show all issues

    snake_case

  9. The issue has been resolved. Show all issues

    if they are new then copyright should be 2018 not 2012 :P

  10. The issue has been resolved. Show all issues

    if they are new then copyright should be 2018 not 2013 :P

  11. The issue has been resolved. Show all issues

    if they are new then copyright should be 2018 not 2013 :P

  12. The issue has been resolved. Show all issues

    why double??

  13. The issue has been resolved. Show all issues

    expectedReturningDataProvider

  14. The issue has been resolved. Show all issues

    if they are new then copyright should be 2018 not 2013 :P

  15. 
      
k.woortman
  1. 
      
  2. The issue has been resolved. Show all issues

    This misses the data type. Look at the @var boolean above.

  3. The issue has been resolved. Show all issues

    $this->escaper gets set in the parent constructor as well. Choose either one.

  4. The issue has been resolved. Show all issues

    unsetting $this->escaper is done in the parent destruct as well. Choose one.

  5. 
      
Mathijs
p.valk
  1. 
      
  2. tests/phpunit.xml (Diff revision 2)
     
     
    The issue has been resolved. Show all issues

    please add : <directory>../src/Lunr/Gravity/Database/MariaDB/Tests/</directory>

  3. 
      
Mathijs
pprkut
  1. I'd like to have the MariaDB connection / query builder classes in a separate review first, before adding delete returning functionality.
    Also, the change to not have the simple query builder extend the parent query builder should be done uniformly for MySQL/SQLite in a separate review as well.

  2. An issue was opened. Show all issues

    We typically call those columns

  3. src/Lunr/Gravity/Database/MariaDB/MariaDBSimpleDMLQueryBuilder.php (Diff revision 3)
     
     
     
     
     
     
     
     
    An issue was opened. Show all issues

    you escape columns and then use the unescaped original...

  4. 
      
Mathijs
Review request changed

Status: Discarded

Loading...