Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Summary:

[Vortex] New dispatcher for FCM conditions

Review Request #564 — Created July 9, 2018 and discarded July 9, 2018, 3:42 p.m.

Information
Owner:	k.woortman
Repository:	Lunr
Branch:	fcm_condition_dispatcher
Bugs:
Depends On:	~~563~~
Reviewers
Groups:	lunr
People:

Description

Vortex: New dispatcher for FCM conditions

Testing Done

Unit tests

Issues

5
0
0
0
All Issues: 5

Description	From	Last Updated
for???	smillernl	July 9, 2018, 9:34 a.m.
not really	smillernl	July 9, 2018, 9:34 a.m.
why not make this FCM?	smillernl	July 9, 2018, 9:34 a.m.
Don't think this needs to be generic, conditional is FCM specific.	smillernl	July 9, 2018, 9:34 a.m.
shouldn't this extend your new abstract class?	smillernl	July 9, 2018, 9:34 a.m.

Fix it!

src/Lunr/Vortex/FCM/FCMAbstractPayloadDispatcher.php (Diff revision 1)
Show all issues
```
for???
```
src/Lunr/Vortex/FCM/FCMAbstractPayloadDispatcher.php (Diff revision 1)
Show all issues
```
not really
```
src/Lunr/Vortex/FCM/FCMAbstractPayloadDispatcher.php (Diff revision 1)
Show all issues
```
why not make this FCM?
```
src/Lunr/Vortex/FCM/FCMConditionDispatcher.php (Diff revision 1)
Show all issues
```
Don't think this needs to be generic, conditional is FCM specific.
```

src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1)

Show all issues

shouldn't this extend your new abstract class?

Status: Discarded

Loading...