[Vortex] New dispatcher for FCM conditions

Review Request #564 — Created July 9, 2018 and discarded

k.woortman
Lunr
fcm_condition_dispatcher
563
lunr
Vortex: New dispatcher for FCM conditions

Unit tests

  • 5
  • 0
  • 0
  • 0
  • 5
Description From Last Updated
for??? smillernl smillernl
not really smillernl smillernl
why not make this FCM? smillernl smillernl
Don't think this needs to be generic, conditional is FCM specific. smillernl smillernl
shouldn't this extend your new abstract class? smillernl smillernl
smillernl
  1. 
      
  2. An issue was opened. Show all issues

    for???

  3. An issue was opened. Show all issues

    not really

  4. An issue was opened. Show all issues

    why not make this FCM?

  5. An issue was opened. Show all issues

    Don't think this needs to be generic, conditional is FCM specific.

  6. src/Lunr/Vortex/FCM/FCMDispatcher.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
    An issue was opened. Show all issues

    shouldn't this extend your new abstract class?

  7. 
      
k.woortman
Review request changed

Status: Discarded

Loading...