[Gravity] Add tmp_file and rm functions for the filesystem

Review Request #560 — Created May 30, 2018 and submitted

smillernl
Lunr
gravity/tmp_rm
556
2f6ed85...
lunr
Gravity: Add tmp_file and rm functions for the filesystem


  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
There are no open issues
smillernl
pprkut
  1. 
      
  2. The issue has been resolved. Show all issues

    sorry, no. Not yet :)

  3. src/Lunr/Gravity/Filesystem/Tests/PhysicalFilesystemAccessObjectRmTest.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    All other tests for the FAO actually work with real filesystem events. So you should actually delete real files here ;)

  4. src/Lunr/Gravity/Filesystem/Tests/PhysicalFilesystemAccessObjectTmpTest.php (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    these should also not use mocks

  5. 
      
smillernl
pprkut
  1. 
      
  2. src/Lunr/Gravity/Filesystem/Tests/PhysicalFilesystemAccessObjectRmTest.php (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
    The issue has been resolved. Show all issues

    That's a bit hard to follow. Why two asserts?

  3. The issue has been resolved. Show all issues

    assertFileExists

  4. The issue has been resolved. Show all issues

    assertFileNotExists

  5. The issue has been resolved. Show all issues

    assertStringStartsWith() ?

  6. 
      
smillernl
pprkut
  1. Ship It!
  2. 
      
smillernl
Review request changed

Status: Closed (submitted)

Change Summary:

Merged into master

Loading...