yes the syntax of a WITH statement is exacly the same in sqlite so it will also work on sqlite.

it doesnt reset the entire object it just restores the default values to all the query parts needed for a SELECT statement because otherwise the SELECT statement thats supposed to be inside the WITH statement will also be added at the end of the query.

yeah its technically part of the with statement but the closing brace defines the end of the with statement so thats why i called the function end_sql_with.

this is an option that the user can use the change the name of the result column of the with statement. Found the info about this on this site https://modern-sql.com/feature/with

Ok, that's fine then. Double check that mysql/mariadb/sqlite actually really support that though.

Additionally, optional parameters should be optional. Like you wrote it, it has to be specified all the time, even if you don't care about them. Make them optional by making them the last argument to the function.

Makes sense to keep this the same as column_names(), yes

okay i have changed the parameter to an array instead so a list of strings an be used

this is to take all the strings out of the array add commas between the strings and wrap the string in parentheses so that the result will look like this examle:

'( columname1, columname2, columname3 )'.
perhaps i can make this clearer by using a for each loop to get the string out of the array?

How is that different from
'(' . implode(', ', $column_names) . ')'
?

turns out it isnt different

;)

yes a CTE is only used with select queries

i created it when i was thinking about all possible ways to create a unit test but in hindsight its kinda useless

thats not used anywhere else in the code for similar statements tho

better check with heinz, not sure myself.

i tought most of the time empty() and isset() was prefered.

Not if you only want to check for an empty string. Which you're not doing here.

In doubt, keep it consistent with the rest of the code. I don't mind changing it, but then it should be changed everywhere, and that should be a separate review

okay so in that case this line is consistent with the rest of the code which means issue dropped or fixed?

I don't think you fixed anything about it right?